search

IdeaGinkgo / Intellij-Ginkgo

Idea plugin for running and viewing ginkgo tests
GNU General Public License v3.0
34 stars 13 forks source link

Update plugin to be installable on 2021.3 EAP builds #18

Closed adammw closed 3 years ago

adammw commented 3 years ago

Currently running 2021.3 EAP as my daily driver IDE and wanted to test out the plugin, requiring me to change this property. Haven't checked out the changelog yet to see if any other APIs need changing.

TaylorOno commented 3 years ago

Did you compile and try it against EAP? I don't know if I can blindly trust the Plugin Verifier or if I should do manual tests.

TaylorOno commented 3 years ago

I merged this change along with some other updates in this commit https://github.com/IdeaGinkgo/Intellij-Ginkgo/commit/43451f71752f5fcf81cdb9d66ea39136f96d7732

adammw commented 3 years ago

I did notice one thing that might be related to the EAP build - the focus string for nested tests comes out in the incorrect order, that is if I have:

Describe("A", func() {
  Context("B", func() {
    It("C", func() { })
  }
})

that the gutter play button will try and focus "C B A" instead of "A B C"

TaylorOno commented 3 years ago

that was my bad I introduced that bug I think but it should be fixed on the 0.2.0 release