search

IdeaGinkgo / Intellij-Ginkgo

Idea plugin for running and viewing ginkgo tests
GNU General Public License v3.0
33 stars 12 forks source link

Can't run tests in v0.7.0-beta: java.io.FileNotFoundException #64

Closed vmallet closed 1 year ago

vmallet commented 1 year ago

Freshly installed v0.7.0-beta on a freshly restarted IDEA (macOS 12.5): Tried to run the Run Configuration that worked earlier today w/ v0.6.5 and I got a notification: java.io.FileNotFoundException: ginkgo-output-2022-11-04 (Read-only file system) (in the notification area) Test didn't run.

vmallet commented 1 year ago

Ok so it looks like there's a FileWriter being created in GinkgoTestEventsConverter.java

    fileWriter = new FileWriter("ginkgo-output-"+LocalDate.now());

This FileWriter is attempting to create a file in the "current directory", which in my case is / and it doesn't jibe with macOS.

I prepped a PR with a fix for it to put it nicely in a temp dir, but then I realized this looks more like a bit of debug functionality than something useful and it could probably be removed (i.e. it doesn't seem to be necessary for the actual work of the plugin). I can submit it if you want or you could deal with it just as easily.

With the fix done locally the plugin works quite nicely!

TaylorOno commented 1 year ago

I must have accidentally committed that code, I use it to generate outputs for testing, Ive removed it from master.