IdeaGinkgo / Intellij-Ginkgo

Idea plugin for running and viewing ginkgo tests
GNU General Public License v3.0
34 stars 13 forks source link

False negative result: test suite passed but GoLand says "Tests failed" #84

Closed Antonboom closed 1 year ago

Antonboom commented 1 year ago

Hello!

Thank u for plugin.

I have a simple code in the tests:

var _ = BeforeSuite(func() {
    suiteCtx, suiteCtxCancel = context.WithCancel(context.Background())
    DeferCleanup(suiteCtxCancel)

        // ...

And manual ginkgo run finished without errors:

$ ginkgo --fail-fast --timeout=20s --tags e2e ./tests/e2e  
Running Suite: E2E Suite - /Users/anthony/writing-go-service.solutions/tests/e2e
================================================================================
Random Seed: 1682140495

Will run 17 of 17 specs
•••••••••••••••••

Ran 17 of 17 Specs in 9.295 seconds
SUCCESS! -- 17 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 11.315209875s
Test Suite Passed

But through plugin:

Screenshot 2023-04-22 at 08 10 53 Screenshot 2023-04-22 at 08 13 34
TaylorOno commented 1 year ago

Should be fixed in v0.9.4