search

Idean / sonar-swift

Open source Swift plugin for SonarQube (also supports Objective-C)
Other
896 stars 276 forks source link

Prevent confusion with the commercial plugin #1

Closed Stephan202 closed 8 years ago

Stephan202 commented 8 years ago

I just dropped sonar-swift-plugin-0.1.jar into our SonarQube 5.2 installation. It's recognized just fine, quality profiles and rules and all, which is nice :). (Can't give feedback on analysis results yet; I'm not involved in Swift development in our company, and I haven't communicated yet that I installed this plugin.)

But when I go to the Update Center, it suggests that I upgrade the plugin from version 0.1 to 1.5, with a link to the home page and release notes of the commercially available/official Swift plugin. That's quite confusing, and probably not what you want. :)

zippy1978 commented 8 years ago

Thank you @Stephan202 !

I forgot to check that... I will fix it in the next release.

Gilles

giacgbj commented 8 years ago

:+1:

giacgbj commented 8 years ago

Is there a reason you don't close this ticket? It's the fourth release after the "next release".

It's not only a matter of confusion regarding the aforementioned information: if you automatically update your plugin, the downloaded file is actually https://sonarsource.bintray.com/CommercialDistribution/sonar-swift/sonar-swift-plugin-1.5.1.jar (from http://www.sonarsource.com/products/plugins/languages/swift/).

The result is that you wipe out your plugin and install the commercial one! :-)

zippy1978 commented 8 years ago

Hi I know... But I did not manage to find on which id/property of the plugin the Update Center relies on yet...

rompic commented 8 years ago

https://github.com/octo-technology/sonar-objective-c/issues/88

There was a similar Problem with sonar objective-c

zippy1978 commented 8 years ago

Ok,

So, I just need to change the language key and few other things. But I don't know what key to use yet.... "swift" was good :), anything else will not be as readable / understandable...

Your ideas are welcomed !

rompic commented 8 years ago

swift-ce ?

gretzki commented 8 years ago

swiftos (for open source), swifty, swifflemanizzle

You're welcome! ;P

zippy1978 commented 8 years ago

Hi,

I changed everything as detailed in PR https://github.com/octo-technology/sonar-objective-c/issues/88.

But still the confusion remains in the update center....

Any ideas ?

zippy1978 commented 8 years ago

Finally fixed ! And I did not have to change language key.

It is available in release 0.2.2