search

Idein / actfw-core

Core components of actfw, independent of specific devices
MIT License
3 stars 0 forks source link

usege of `v4lconvert_try_format` is wrong #36

Open nomaddo opened 3 years ago

nomaddo commented 3 years ago

https://github.com/Idein/actfw-core/blob/563c2c55a1081c3c0071701e802c09c0da4f3fbe/actfw_core/v4l2/video.py#L548-L574

The header file says:

https://github.com/philips/libv4l/blob/master/include/libv4lconvert.h#L63-L75

The function v4lconvert_try_format is not for check whether we can convert pictures from src_fmt to dest_fmt: The function is to get src_fmt which we finally get dest_fmt.

nomaddo commented 3 years ago

And, v4lconvert_try_format may change dest_fmt. The checking is lack.