search

IdentityManager / IdentityManager.AspNetIdentity

ASP.NET Identity support for Thinktecture IdentityManager
Apache License 2.0
60 stars 51 forks source link

We really need a way to define how to parse TUserKey and TRoleKey. #10

Closed nicholi closed 9 years ago

nicholi commented 9 years ago

There was no way to specify how to parse a generic TKey type, the constructor just threw an exception for any of the non-default types you've handled by guessing type.

Can't override the base class because there is no default empty constructor. So the dev would have to checkout src, modify to add their own parsing for TKey, and build their own binary.... or just allow them to specify how to parse it.

nicholi commented 9 years ago

Ping!

Reminder this is the same issue as in IdentityServer.v3.AspNetIdentity merged in this PR (https://github.com/thinktecture/Thinktecture.IdentityServer.v3.AspNetIdentity/pull/27). Would have liked to see this in today's build...but oh well.

nicholi commented 9 years ago

Nm, just noticed you manually copied in the code. With one minor copy/paste bug, https://github.com/thinktecture/Thinktecture.IdentityManager.AspNetIdentity/issues/11