search

IdentityModel / oidc-client-js

OpenID Connect (OIDC) and OAuth2 protocol support for browser-based JavaScript applications
Apache License 2.0
2.43k stars 840 forks source link

Incorrect way to set iframe width and height #1237

Closed AlexanderBaggett closed 3 years ago

AlexanderBaggett commented 4 years ago

The oidc-client uses the incorrect way to set Iframe height and width. Iframe height and width are not controlled by CSS style properties but directly through width and height properties.

So this: this._frame.style.width = 0; this._frame.style.height = 0;

should be this: this._frame.height = 0; this._frame.width = 0;

AlexanderBaggett commented 4 years ago

I figured this out when I needed to debug and made them visible. Changing the style properties didn't affect the width and height.

brockallen commented 4 years ago

Mind sending a PR?

AlexanderBaggett commented 4 years ago

No problem. Here you go.

https://github.com/IdentityModel/oidc-client-js/pull/1240

brockallen commented 3 years ago

merged, thx!