search

IdentityModel / oidc-client-js

OpenID Connect (OIDC) and OAuth2 protocol support for browser-based JavaScript applications
Apache License 2.0
2.43k stars 841 forks source link

getEpochTime should not be part of OidcClientSettings interface #1287

Closed wollardj closed 3 years ago

wollardj commented 3 years ago

I've just tried updating a project to 1.11.0 and am getting a type error because we don't define getEpochTime. Should getEpochTime have been optional in OidcClientSettings? All of the other properties are.

Originally posted by @notclive in https://github.com/IdentityModel/oidc-client-js/pull/1271#issuecomment-769877657

wollardj commented 3 years ago

This should be address by #1286

mahivrgit commented 3 years ago

@wollardj Thanks. we are also facing the same issue.

Property 'getEpochTime' is missing in type '{ authority: string; client_id: string; redirect_uri: string; response_type: string; scope: string; filterProtocolClaims: true; loadUserInfo: false; response_mode: string; revokeAccessTokenOnSignout: true; metadata: { ...; }; }' but required in type 'UserManagerSettings'.

McGern commented 3 years ago

Also getting the same issue. Is there a quick workaround?

brockallen commented 3 years ago

Just released a path for it. Let me know if it's still an issue, please.