search

IdentityModel / oidc-client-js

OpenID Connect (OIDC) and OAuth2 protocol support for browser-based JavaScript applications
Apache License 2.0
2.43k stars 842 forks source link

v1.11.3 breaks signout for me #1298

Closed Snaptags closed 3 years ago

Snaptags commented 3 years ago

In my code I use

  userManager.removeUser();
  userManager.signoutRedirect().finally(null);

to logout the user. This does not work after updating to v1.11.3.

The Chrome network tab showed this for v1.10.1: before

After the update I get: after

Some kind of redirect seems to be triggered now, cancelling the actual logout call.

brockallen commented 3 years ago

In all of my tests, signout is working, so it's hard to say. Can you debug into it more and report back?

brockallen commented 3 years ago

Also, you don't need to call removeUser -- it's called from inside of signoutRedirect.

Snaptags commented 3 years ago

Thank you for the hint. Will remove the obsolete call and do some debugging…

GolfForSale commented 3 years ago

@Snaptags, have you found solution. Similar issue occurs for me.

Snaptags commented 3 years ago

Actually: I cannot reproduce the issue using the latest v1.11.4… BUT: removing removeUser breaks it again for me.

brockallen commented 3 years ago

BUT: removing removeUser breaks it again for me.

Hmm, then I"m not sure -- you'd have to debug if you wanted to get to the bottom of it. But if it's now working again, then perhaps there's nothing to do here.

brockallen commented 3 years ago

Ok, I'll close for now. If there's something else on this then please reopen.