IdentityModel / oidc-client-js

OpenID Connect (OIDC) and OAuth2 protocol support for browser-based JavaScript applications
Apache License 2.0
2.43k stars 842 forks source link

Add "client_authentication" parameter to index.d.ts #1313

Open andioli opened 3 years ago

andioli commented 3 years ago

First of all, thank you for adding basic authentication with #1060.

Yet, the client_authentication parameter is still missing in the index.d.ts file. It would be great, if you could add this line: client_authentication: string to OidcClientSettings.

Without this parameter, it's not really usable with Typescript projects.

Thanks in advance! :)

brockallen commented 3 years ago

Feel free to send a PR, please?

frontendplace commented 3 years ago

it should be: client_authentication? : string

can anybody make PR for this: in node_modules/oidc-client/index.d.ts I am not allowed to push changes

line 126: export interface OidcClientSettings { / The URL of the OIDC/OAuth2 provider */ authority?: string; readonly metadataUrl?: string; /* Provide metadata when authority server does not allow CORS on the metadata endpoint / metadata?: Partial; / Provide signingKeys when authority server does not allow CORS on the jwks uri */ signingKeys?: any[]; / Your client application's identifier as registered with the OIDC/OAuth2 */ client_id?: string; client_secret?: string; /* The DefaultClientAuthentication is 'client_secret_post' and can be set back to standard 'client_secret_basic' / client_authentication? : string / The type of response desired from the OIDC/OAuth2 provider (default: 'id_token') */

willmcclellan commented 3 years ago

Added this in #1390