IdentityModel / oidc-token-manager

Apache License 2.0
51 stars 36 forks source link

Duplicate DefaultHttpRequest in dist #24

Closed jkabonick-ft closed 9 years ago

jkabonick-ft commented 9 years ago

I noticed that the oidc-token-manager in the dist folder contains two copies of some of the referenced libraries. This appears to be due to the inclusion of the oidc-client which itself includes these libraries as well.

The gulp file lists the oidc-client after the token-manager libraries so the oidc-client copy of these libraries will override the copies included here. Is that the intent? Is there a reason these libraries (defaultHttpRequest, defaultPromiseFactory) are referenced by the token manager when they are already included in the oidc-client?

I have some changes for an IE9 issue I'd like to put into a pull request for issue https://github.com/IdentityModel/oidc-token-manager/issues/15, but I'm not sure which copy of the defaultHttpRequest to use for my changes.

It seems that either of the following could resolve this: 1) The gulp file order can be changed so that the token-manager libraries are included after the oidc-client code in which case they would override the behavior of the oidc-client 2) Drop the references to the libraries in favor of using the libraries referenced by oidc-client.