[Documentation] CryptoJWT is only supported in python3.6 and newer

IdentityPython / JWTConnect-Python-CryptoJWT

An implementation of RFC 7515-18 using Cryptography

Apache License 2.0

13 stars 16 forks source link

[Documentation] CryptoJWT is only supported in python3.6 and newer #24

Closed peppelinux closed 4 years ago

peppelinux commented 5 years ago

Because of f-strings

Traceback (most recent call last):
  File "~/DEV3/OIDC-Project/env/bin/jwkgen", line 6, in <module>
    from cryptojwt.tools.keygen import main
  File "~/DEV3/OIDC-Project/env/lib/python3.5/site-packages/cryptojwt/tools/keygen.py", line 46
    help=f'RSA public key exponent (default {DEFAULT_RSA_EXP})',
                                                              ^
SyntaxError: invalid syntax

I'll try to put in a PR a python badge into the Readme

rohe commented 5 years ago

You think we should include 3.5 ?

peppelinux commented 5 years ago

You think we should include 3.5 ?

If oidcservice would be implemented into SATOSA -> yes I dugged into source code and the only 3.6 dependencies are those f-strings in argparse, probably we could do without it.

rohe commented 5 years ago

Definitely! So, do you or I remove the f-strings ?

peppelinux commented 5 years ago

I'm doing it, I'll put it in the pending PR with fixed badges

rohe commented 5 years ago

Too fast for you :-) Already approved that !

peppelinux commented 5 years ago

Too fast for you :-) Already approved that ! when i grow up i wanna be like you!

Here https://github.com/openid/JWTConnect-Python-CryptoJWT/pull/26

jschlyter commented 4 years ago

I believe this can be closed?

peppelinux commented 4 years ago

Yes