search

IdentityPython / JWTConnect-Python-OidcMsg

Implementation of OIDC protocol messages
Apache License 2.0
3 stars 10 forks source link

Allow a class attribute to be either a dictionary or a class instance… #39

Closed rohe closed 3 years ago

rohe commented 3 years ago

… that acts as a dictionary.

This comes from the need for having a client database separate from the session database. And having the specification of that database in the server configuration.

codecov-commenter commented 3 years ago

Codecov Report

Merging #39 (1e40696) into develop (8d23cfd) will decrease coverage by 1.05%. The diff coverage is 63.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
- Coverage    78.02%   76.97%   -1.06%     
===========================================
  Files           15       17       +2     
  Lines         2426     2619     +193     
===========================================
+ Hits          1893     2016     +123     
- Misses         533      603      +70
Impacted Files Coverage Δ
src/oidcmsg/storage/abfile.py 57.59% <57.59%> (ø)
src/oidcmsg/util.py 80.76% <88.88%> (+18.26%) :arrow_up:
src/oidcmsg/impexp.py 77.16% <92.85%> (+1.94%) :arrow_up:
src/oidcmsg/__init__.py 51.16% <100.00%> (ø)
src/oidcmsg/storage/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d23cfd...1e40696. Read the comment docs.

peppelinux commented 3 years ago

Two questions

  1. Why Is this in oidcmsg and not directly in oidc-op?
  2. Is there the way to define another class in oidc-op configuration to have another storage instead of files?

The last answer Is true for sure :)

peppelinux commented 3 years ago

Ok here https://github.com/IdentityPython/oidc-op/pull/105

rohe commented 3 years ago
  1. Since I thought it was part of the dump/load/flush system. In this PR I defined DICT_TYPE can imaging there being more special types down the line.
  2. Yes :-)