IdentityPython / SATOSA

Proxy translating between different authentication protocols (SAML2, OpenID Connect and OAuth2)
https://idpy.org
Apache License 2.0
200 stars 123 forks source link

docs: add name and description to example SAML2 backend #393

Closed melanger closed 2 years ago

melanger commented 2 years ago

These attributes are required to generate valid metadata in combination with required_attributes and/or optional_attributes.

Without these attributes specified (and there is no hint in pysaml2 docs about this either), the generated metadata contains empty <ns0:ServiceName xml:lang="en" /> inside AttributeConsumingService, which is invalid. This was probably the cause of pysaml2#345

melanger commented 2 years ago

Please consider updating the docs as well and/or adding a check for this in code, either here or in pysaml2.

c00kiemon5ter commented 2 years ago

thank you!