Filter attributes by shibmd_scope

[vladimir-mencl-eresearch]

All Submissions:

• [X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• [X] Have you added an explanation of what problem you are trying to solve with this PR?
• [X] Have you added information on what your changes do and why you chose this as your solution?
• [x] Have you written new tests for your changes?
• [X] Does your submission pass tests?
• [X] This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Fix #297 by extending satosa.micro_services.attribute_modifications.FilterAttributeValues to support not only regexp filtering but also add filter types shibmdscope_match_scope and shibmdscope_match_value - equivalent to https://shibboleth.atlassian.net/wiki/spaces/IDP4/pages/1272053894/ScopeMatchesShibMDScope and https://shibboleth.atlassian.net/wiki/spaces/IDP4/pages/1272053892/ValueMatchesShibMDScope from the Shibboleth project.

@c00kiemon5ter , please let me know whether you are happy with the overall approach - in #297, you indicated this should be done in a microservice - and in the end, it wasn't that hard.

I first thought I'd do this in a new microservice, but I'd just be replicating what FilterAttributeValues does - and this additional filtering fits in there conceptually well.

If happy with this approach, I'd add documentation and tests - but please let me know if overall happy with the approach I took.

Cheers, Vlad

[c00kiemon5ter]

@vladimir-mencl-eresearch I think it's fine! Please, go ahead 👍

[vladimir-mencl-eresearch]

Hi @c00kiemon5ter , I've now added tests - and also made a few tweaks, incl. removing the unnecessary re.compile - and switched to re.fullmatch as discussed.

I think it's now ready for a proper review - please let me know what you think needs to get done to get it merged.

Thanks a lot in advance for getting back to me.

Cheers, Vlad