search

IdentityPython / djangosaml2

Django SAML2 Service Provider based on pySAML2
Apache License 2.0
254 stars 143 forks source link

Separate out the condition for skipping login #376

Closed CamLamb closed 1 year ago

CamLamb commented 1 year ago

The LoginView class has a get method that begins with some logic to determine if the login form should be presented to the current user. If someone wants to override this logic, they have to override the whole get method.

This PR separates the conditions into an overridable method so the get method can focus on building the login form/page.

peppelinux commented 1 year ago

It good look, thank you @jafacakes2011 !

Can I ask you also to increase the version here https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30

up to 1.5.8? Then I'll do tests and we'll have a brand new release thank to you :-)

peppelinux commented 1 year ago

It good look, thank you @jafacakes2011 !

Can I ask you also to increase the version here https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30

up to 1.5.8? Then I'll do tests and we'll have a brand new release thank to you :-)

CamLamb commented 1 year ago

Thanks @peppelinux! I've bumped the package version as requested 😄

CamLamb commented 1 year ago

Hi @peppelinux, just nudging on this to see if we can get it merged 😄