search

IdentityPython / oidc-op

An implementation of an OIDC Provider (OP)
Apache License 2.0
65 stars 27 forks source link

documentation inconsistency #142

Closed melanger closed 3 years ago

melanger commented 3 years ago

In many tests and examples, including the main example, the configuration option for claims is written as add_claim_by_scope (singular claim), but in the source code, it is add_claims_by_scope (plular claims):

https://github.com/IdentityPython/oidc-op/blob/a87177e7a5d0b40dcff11ed75b39a72bd2d3f015/src/oidcop/session/claims.py#L28

https://github.com/IdentityPython/oidc-op/blob/a87177e7a5d0b40dcff11ed75b39a72bd2d3f015/src/oidcop/oidc/userinfo.py#L38

I guess the documentation and tests should be fixed to add_claims_by_scope.

peppelinux commented 3 years ago

Think you're right @nsklikas can you confirm this?

@melanger feel free to put your contribution with a Pull Request, thank you