search

IdentityPython / pyFF

SAML metadata aggregator
https://pyff.io/
Other
50 stars 37 forks source link

invalid MDQ response when entityID ends with .xml #193

Open skoranda opened 4 years ago

skoranda commented 4 years ago

pyFF does not return SAML metadata when the entityID in the MDQ query ends with '.xml' and the request includes the header

Accept: application/samlmetadata+xml

The draft MDQ spec can be found at

https://github.com/iay/md-query/blob/master/draft-young-md-query-saml.txt

Code Version

Commit 7705880df77538f5d34976da5e26db1f80a75e53

Expected Behavior

pyFF should return SAML metadata (XML) in response to an MDQ query for entityIDs that end in ".xml" when the request includes the header

Accept: application/samlmetadata+xml

Current Behavior

When the entityID ends in '.xml' no SAML metadata is returned for the entity with that entityID even when the header is 

Accept: application/samlmetadata+xml

Steps to Reproduce

Prepare a pyFF that parses the metadata aggregate at

http://mds.swamid.se/md/swamid-2.0.xml

and then try

curl \
-H 'Accept: application/samlmetadata+xml' \
http://localhost/entities/https%3A%2F%2Flogin.idp.eduid.se%2Fidp.xml
leifj commented 1 year ago

I believe this was fixed with the content negotiation policy feature yes?

skoranda commented 1 year ago

Sorry, I don't have a pyFF deployment anymore with which I can test.