search

IdentityPython / pyjwkest

Implementation of JWT, JWS, JWE and JWK
Apache License 2.0
92 stars 55 forks source link

Allow request kwargs #81

Closed zulrang closed 5 years ago

zulrang commented 6 years ago

Allow load_x509_cert and KEYS.load_from_url to accept kwargs to pass through to request

zulrang commented 6 years ago

Tests would not pass before the change.

zulrang commented 6 years ago

Fixes https://github.com/IdentityPython/pyjwkest/issues/80

rohe commented 6 years ago

I have nothing against the PR as such but I don't like that so many tests doesn't pass. When did this happen ?

zulrang commented 6 years ago

If I just git clone master and run tox, I get the same failures on an EC2 instance.

rohe commented 6 years ago

OK, I'll fix the tests but probably not until tomorrow.

rohe commented 6 years ago

I've push some changes. Can you verify that the tests works now. They do for me.

zulrang commented 6 years ago

I'm not seeing any changes. Last commit was from Oct. https://github.com/IdentityPython/pyjwkest/commit/0c75bc631d1fae5e190d857fc616c4cba5be6b31