sigver.correctly_signed_response is not using `must` param

IdentityPython / pysaml2

Python implementation of SAML2

Apache License 2.0

555 stars 422 forks source link

sigver.correctly_signed_response is not using `must` param #736

Open obrodnikov-amplify opened 3 years ago

obrodnikov-amplify commented 3 years ago

Code Version

6.2.0

Expected Behavior

calling sigver.correctly_signed_response(*xml without <Signature>*, must=True) should raise some Exception due to missing Signature. Because docstring states ":param must: Whether there must be a signature"

Current Behavior

no exception is raised

Possible Solution

deprecate must param

c00kiemon5ter commented 3 years ago

Thanks for the report; I agree that must should be deprecated and the API should be simplified.

peppelinux commented 3 years ago

@c00kiemon5ter in which kind of roadmap/milestone should we handle this topic?