search

IdentityPython / pysaml2

Python implementation of SAML2
Apache License 2.0
555 stars 422 forks source link

Incorrect domain validation #950

Open StuBz211 opened 8 months ago

StuBz211 commented 8 months ago

Incorrect domain validation since 2013 https://github.com/IdentityPython/pysaml2/commit/68ab79f49d752bd4905457f61d9a8e033141a403 (spaces between 1 in regular expression- it's a first problem)

Code Version

7.5.0

Expected Behavior

Domain's validating success

Current Behavior

regexp doesn't work

Possible Solution

To update validation domain regexp

Steps to Reproduce

from saml2.validate import valid_domain_name

valid_domain_name('simple.domain.com')

and getting an error ValueError("Not a proper domain name")

StuBz211 commented 8 months ago

Fix is coming folks! https://github.com/IdentityPython/pysaml2/pull/951