search

IdentityPython / pysaml2

Python implementation of SAML2
Apache License 2.0
548 stars 422 forks source link

bugfix: domain name validation. #951

Open StuBz211 opened 5 months ago

StuBz211 commented 5 months ago

Updated regexp for domain validation Add testcases for domain validation

fix issue: https://github.com/IdentityPython/pysaml2/issues/950

fix small bug with domain validation

c00kiemon5ter commented 2 months ago

The original issue is due to the change from {1} to { 1 }.

This PR introduces a new regex. I would be good to have an explanation about the regex itself.

Further, we could also reuse existing packages for this purpose, like validators.

StuBz211 commented 2 months ago

The original issue is due to the change from {1} to { 1 }.

yep, but I found other problems with that regex. So what we decide to do? To use validators it's a good idea