IdentityPython / pysaml2

Python implementation of SAML2
Apache License 2.0
555 stars 422 forks source link

Python xmlsec library support #961

Open AndrewFoxUUID opened 4 months ago

AndrewFoxUUID commented 4 months ago

Description

The feature or problem addressed by this PR
What your changes do and why you chose this solution

Checklist

c00kiemon5ter commented 4 months ago

Hello and thank you for this contribution. I'd like to suggest to make the changes on their own class as a new crypto backend, to keep the new functionality clean. Or, is the intention to use XMLSecurity and the xmlsec module along side each other?

AndrewFoxUUID commented 4 months ago

Hello and thank you for this contribution. I'd like to suggest to make the changes on their own class as a new crypto backend, to keep the new functionality clean. Or, is the intention to use XMLSecurity and the xmlsec module along side each other?

My understanding of the current codebase is that the XmlSecurityBackend is already using xmlsec, it just hasn't been updated to use xmlsec's newest functionalities, and isn't nearly as developed as the XmlSec1 backend. The main purpose of these changes is to use xmlsec instead of creating a terminal flow to execute a libxmlsec1 call for better efficiency.

af-splashtop-test commented 4 months ago

@c00kiemon5ter 654151 Can you please review these changes?