IdentityServer / IdentityServer3.AccessTokenValidation

OWIN Middleware to validate access tokens from IdentityServer3
Apache License 2.0
90 stars 150 forks source link

Remove secondary middleware caching #144

Closed andrew-laughlin closed 7 years ago

andrew-laughlin commented 7 years ago

See issue: #https://github.com/IdentityServer/IdentityServer3.AccessTokenValidation/issues/143

dnfclas commented 7 years ago

@andrew-laughlin, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects. Thanks, .NET Foundation Pull Request Bot

brockallen commented 7 years ago

Thanks Andrew -- a few asks: 1) Can you sign the CLA, please?, and 2) Can you rework the PR to only make the code changes, and not the dependency updates?

Thanks.

dnfclas commented 7 years ago

@andrew-laughlin, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

andrew-laughlin commented 7 years ago

@brockallen updates made, please take a look.

brockallen commented 7 years ago

great, thanks!

leastprivilege commented 7 years ago

nuget pushed

ErikEJ commented 7 years ago

It looks like this change causes thread deadlocks/hangs under heavy load (many request running under ASP.NET) - why was the quick exit removed? https://github.com/IdentityServer/IdentityServer3.AccessTokenValidation/commit/dec7f5c14784ddcaeb3c99aaf3cced7ddf22eed1#diff-5b2c5cc8b17ae721dd148a69c90508e6L136