added SyncMetadataImmediately option to IdentityServerBearerTokenAuthenticationOptions

IdentityServer / IdentityServer3.AccessTokenValidation

OWIN Middleware to validate access tokens from IdentityServer3

Apache License 2.0

90 stars 149 forks source link

added SyncMetadataImmediately option to IdentityServerBearerTokenAuthenticationOptions #61

Closed tugberkugurlu closed 8 years ago

tugberkugurlu commented 8 years ago

Damn GitHub! Pressed the Enter by mistake :smile:

fixes #57.

I added SyncMetadataImmediately option to IdentityServerBearerTokenAuthenticationOptions which makes it evaluate the metadata sync in a lazy manner. It's true by default. Implementation felt a bit nasty. so, I am not sure if there is a better way to be handling this.

I also used a C# 6.0 feature. I am not sure if the build server is configured to build properly. I can remove it if that's not preferred.

dnfclas commented 8 years ago

Hi @tugberkugurlu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

leastprivilege commented 8 years ago

Hi - thanks - couple of comments

Could you do the PR against dev
Please remove C# 6 features for now
Could you rename the property to DelayLoadMetadata and default to false

tugberkugurlu commented 8 years ago

sorry, keep forgetting about dev branch :s will do that.