Use the kid from the JsonWebKey as the id for the X509SecurityToken

IdentityServer / IdentityServer3.AccessTokenValidation

OWIN Middleware to validate access tokens from IdentityServer3

Apache License 2.0

91 stars 149 forks source link

Use the kid from the JsonWebKey as the id for the X509SecurityToken #85

Closed omerlh closed 8 years ago

omerlh commented 8 years ago

Hey The X509SecurityToken created from the key was created with default random id. I've changed it to be the id of the key instead. This was not a bug, because the JWT handler was looking for a key based on the x5t that present in the JWT and in the JWK. In my situation the JWT will not necessary will have a x5t (as it will not be signed using X509Certificate) so I need to filter the keys by the id. This, among with my previous PR allow my to accomplish that. Thanks, Omer

dnfclas commented 8 years ago

Hi @omerlh, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

leastprivilege commented 8 years ago

ok - done