search

IdentityServer / IdentityServer3.AccessTokenValidation

OWIN Middleware to validate access tokens from IdentityServer3
Apache License 2.0
91 stars 149 forks source link

Set response CORS headers if not already present #96

Closed mderriey closed 8 years ago

mderriey commented 8 years ago

When a valid token is found in the request but the scope requirement isn't met, CORS headers are set on the response from the values of several request headers. This potentially conflicts if CORS headers were already set on the response, for example by the CORS middleware.

dnfclas commented 8 years ago

Hi @mderriey, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

leastprivilege commented 8 years ago

https://ci.appveyor.com/project/leastprivilege/thinktecture-identityserver-v3-accesstokenvalidati/build/2.0.80

mderriey commented 8 years ago

sorry about that

leastprivilege commented 8 years ago

for the 3-series we decided to stay on C# 5. (for now)

leastprivilege commented 8 years ago

thanks!

mderriey commented 8 years ago

Have you tried playing with the $psake.build_success variable in build.ps1 to fail the build when there's an error in the process? I can see you asked about it already.

Happy to try fixing this even though we'll have to trial and error as $LASTEXITCODE is 1 when the build fails on my local machine.

leastprivilege commented 8 years ago

Give it a go. I am mostly interested in this for the main identityserver repo (as a start at least)