IdentityServer / IdentityServer3.AspNetIdentity

ASP.NET Identity support for Thinktecture IdentityServer3
Apache License 2.0
64 stars 51 forks source link

Don't require user manager to support user login in AuthenticateLocalAsync #14

Closed larrifax closed 10 years ago

larrifax commented 10 years ago

For UserManager.SupportsUserLogin to be true, the UserStore needs to implement IUserLoginStore. This interface "maps users to login providers, i.e. Google, Facebook, ..." according to its documentation.

AFAIK, this should not be needed when authenticating locally. Hence, you should change the UserManager requirement to be UserManager.SupportsUserPassword, as the UserStore needs to implement the IUserPasswordStore interface in order for the UserManager.CheckPasswordAsync call to work.

brockallen commented 10 years ago

Ah, good catch -- shows you how well named their APIs are.

Thx.