search

IdentityServer / IdentityServer3.AspNetIdentity

ASP.NET Identity support for Thinktecture IdentityServer3
Apache License 2.0
64 stars 51 forks source link

We really need a way to define how to parse TKey #27

Closed nicholi closed 9 years ago

nicholi commented 9 years ago

Sorry about previous PR to master branch, I take it that was the main problem?

There was no way to specify how to parse a generic TKey type, the constructor just threw an exception for any of the non-default types you've handled by guessing type.

Can't override the base class because there is no default empty constructor. So the dev would have to checkout src, modify to add their own parsing for TKey, and build their own binary.... or just allow them to specify how to parse it.

brockallen commented 9 years ago

I don't see that you've signed the CLA. Please do so.

nicholi commented 9 years ago

I did it right before I pushed the PR.

nicholi commented 9 years ago

Signed again for IdentityServer and IdentityManager.

brockallen commented 9 years ago

Ok thanks -- and sorry for that hassle. Microsoft is trying to make it more automatic where we get updates when people sign, but they're not there yet. Sorry for making you do it twice.

brockallen commented 9 years ago

Also, I like the uint support. thanks again.