IdentityServer / IdentityServer3.AspNetIdentity

ASP.NET Identity support for Thinktecture IdentityServer3
Apache License 2.0
64 stars 51 forks source link

EmailConfirmed on LocalAuthentication. #7

Closed carzogliore closed 9 years ago

carzogliore commented 10 years ago

Hello,

Just using this version and detect that there is no EmailConfirmed verification on AuthenticateLocalAsync method, it was there in the previous version. Is there a reason that this version does not have that functionality?

Details: On https://github.com/thinktecture/Thinktecture.IdentityServer.v3.AspNetIdentity/blob/master/source/AspNetIdentityUserService/AspNetIdentityUserService.cs

This code snipped was part of the public virtual async Task AuthenticateLocalAsync(string username, string password) on the previous version.

        if (userManager.SupportsUserEmail && 
            !(await userManager.IsEmailConfirmedAsync(user.Id)))
        {
            return null;
        }

I extended it on my local version including that.

Thanks.

Regards. Roberto.

brockallen commented 10 years ago

Sorry -- didn't see this issue until now.

I don't recall, to be honest. I'll leave this open as a reminder to go back and check it. Thx.

brockallen commented 10 years ago

Sorry for taking so long to get back to this -- to be honest I don't recall having it and I think if that check were in here it'd not be acceptable for many people. So this sort of check I am leaving up for the consumer of this library.

brockallen commented 9 years ago

FYI, a PostAuthenticateLocalAsync method was added to allow a simple virtual to override to add this sort of additional check. HTH

carzogliore commented 9 years ago

Thanks Brock.

I'll have a look into this.

Regards, Roberto,.

On Tue, Jan 20, 2015 at 2:06 AM, Brock Allen notifications@github.com wrote:

Closed #7 https://github.com/thinktecture/Thinktecture.IdentityServer.v3.AspNetIdentity/issues/7 .

— Reply to this email directly or view it on GitHub https://github.com/thinktecture/Thinktecture.IdentityServer.v3.AspNetIdentity/issues/7#event-221393921 .