search

IdentityServer / IdentityServer3.EntityFramework

EntityFramework persistence layer for IdentityServer3
Apache License 2.0
68 stars 97 forks source link

Is it possible to support SQL Compact 4.0? #102

Closed mandm-pt closed 8 years ago

mandm-pt commented 8 years ago

I'm trying to use IdentityServer3 with SQL Compact 4.0, I added IdentityServer3.EntityFramework and IdentityServer3.Admin.EntityFramework but I got an error because of Expiration property existent in ScopeSecret and ClientSecret types. If I change both to DateTime, everything seems to work as expected and the database is created.

Is it possible to add support to SQL Compact? Does this make sense? In my case I don't expect to have a big database and I prefer to don't have dependency of a service.

brockallen commented 8 years ago

Well, it sounds like Sql Compact doesn't support the right data types. You'd have to do some mapping I guess.

mandm-pt commented 8 years ago

Exactly, the error is because of unsupported type, in this case DateTimeOffset. But my question is more about if it make sense to have support to this in your library? If yes I'm happy to implement the change, if not why.

Thanks

brockallen commented 8 years ago

At the time we built it, the date time offset worked fine for what we targeted. As for why I'm hesitant to add it, I think it'd be a breaking change and potentially cause disruption for existing deployments.