Open feanz opened 8 years ago
Hi @feanz, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.
TTYL, DNFBOT;
@feanz, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;
Just got around to this now -- I like the idea and sorry for the delay.
resolves #89
Use entity framework extended to run the token clean up process. This pevent the cleanup code pulling the data back before deleting it.
Add an index to the expiry field to improve performance of selection.
This current solution does not include @tbarcelon proposed plan to move the clustered index to expiry. It just adds an extra non clustered index.
Note: I've included a test that I would remove before merging this code it just so you can run it quickly run it to check it works.
I've profiled the sql that gets executed by entityframework extended.
Included execution plan
Less than ideal compared to the alternative but probably good enough.