Open strtdusty opened 8 years ago
The Signout Message Cookie is deleted
This only happens if the response status code is 200, so if you get redirected back to the IdP then the cookie is not removed. Am I missing something?
It is entirely possible that I am missing something. The cookie is removed before redirecting to the IdP. So when you come back from the IdP there is no context/view model.
Ok, I can see if I can repro.
@brockallen I have a repo project available at https://github.com/strtdusty/IS3PostLogoutRedirectExample/
Did the repo project work for you?
I did not yet look at it.
I think I have the same issue here
I never looked into this, but I'll change it to a bug report. The real issue here is that we don't plan on any more enhancement to this project.
Question / Issue
This is somewhat related to issue 2657 but not completely. I believe once that issue is resolved they will move on to this issue.
When logging out of a federated provider (AAD for me) you do not get redirected to the PostRedirectLogoutUri requested. You end up stopped on the ID3 logout view with no text or link to the redirect (those sections of the view model are null). Tracing it back, I am blaming the problem on prematurely removing the Signout Message Cookie.
My proposed solution is to protect the removal of the signout message cookie by changing the Logout method to only call it when it is actually time to render the logout view:
if (context.ShouldRenderLoggedOutPage()) { context.QueueRemovalOfSignOutMessageCookie(id); }
If this makes sense, I would be happy to create a fork/PR for review.