Exception does not show anything in logs ( try/finally)-IdentityServerAuthenticationHandler

IdentityServer / IdentityServer4.AccessTokenValidation

IdentityServer Access Token Validation for ASP.NET Core

Apache License 2.0

544 stars 214 forks source link

Closed lisberPontes closed 5 years ago

lisberPontes commented 5 years ago

Exception does not show anything in logs ( try/finally)-IdentityServerAuthenticationHandler

After some hourse digging why something didn't work properly in localhost (it ended up been a missconfiguration in my ids).

I took the sourcecode and saw that there's a try/finally block without a catch (in case something happen just log it).

lisberPontes commented 5 years ago

I've a commit I wish to send you as a PR:

May I have permissions to create a remote branch and send you a PR ?

Regards,

leastprivilege commented 5 years ago

yes please.

lisberPontes commented 5 years ago

yes please.

I still cannot publish my remote branch in order to send you a PR :(

May you please give permissions to my account so that I can publish my remote branch? Regards, Lisber

leastprivilege commented 5 years ago

You don't need any permissions to do a PR.