search

IdentityServer / IdentityServer4.AccessTokenValidation

IdentityServer Access Token Validation for ASP.NET Core
Apache License 2.0
544 stars 214 forks source link

Update IdentityServerAuthenticationHandler.cs #119

Closed lisberPontes closed 5 years ago

lisberPontes commented 5 years ago

116 - Add Catch, maintain the execution of the 'finally' block. Thus, avoiding throw; inside catch.

lisberPontes commented 5 years ago

Is everything ok within the PR?

Cheers,

leastprivilege commented 5 years ago

Two comments

lisberPontes commented 5 years ago

Two comments

  • changing the line breaks was unnecessary. We don't do code style PRs
  • re-reading it, are you saying that unhandled exceptions are note logged automatically or swalloed - and need to be logged manually?

Hi, The line breaks were added automatically by Resharper (sorry, I hope this doesn't bother you). In relation to the second question, YES, that's exactly what happened to me, I've got a typo in my IDS and I wasn't getting any exception nor error logged. After adding this log I was able to see the exception and fixed it. So it is indeed something that should be added.

leastprivilege commented 5 years ago

thanks!