IdentityServer / IdentityServer4.WsFederation

Sample for implementing WS-Federation IdP support for IdentityServer4
Apache License 2.0
67 stars 53 forks source link

Incorrect parameter used when performing home realm selection #18

Open TheJayMann opened 4 years ago

TheJayMann commented 4 years ago

An issue which has caused me many problems, which I have recently solved, is that, on the netstandard2.0 branch, the wrong parameter is used when the relying party chooses the home realm.

https://github.com/IdentityServer/IdentityServer4.WsFederation/blob/b20a6f96394901c5964fedabb2af603515ef4fbd/src/IdentityServer4.WsFederation/WsFederationReturnUrlParser.cs#L66

The parameter being assigned to the IdP property is the wtrealm parameter, when it should be the Whr parameter. This is correct in the master branch, where it uses the HomeRealm property.