IdentityServer / IdentityServer4

OpenID Connect and OAuth 2.0 Framework for ASP.NET Core

https://identityserver.io

Apache License 2.0

9.21k stars 4k forks source link

fix infinite loop in Token Cleanup after concurrency exception #5437

Closed ajeckmans closed 2 years ago

ajeckmans commented 2 years ago

At this point we cannot accept PRs for new features, only bugfixes. Thanks!

What issue does this PR address? Fix for #4492 on 3.1.x release. Changes copied from https://github.com/IdentityServer/IdentityServer4/pull/4498

Does this PR introduce a breaking change? No.

Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[ ] Unit Tests for the changes have been added (for bug fixes / features)

Other information:

The original PR for the main branch did not include any tests.

leastprivilege commented 2 years ago

Important update

This organization is not maintained anymore besides critical security bugfixes (if feasible). This organization will be archived when .NET Core 3.1 end of support is reached (3rd Dec 2022). All new development is happening in the new Duende Software organization.

The new Duende IdentityServer comes with a commercial license but is free for dev/testing/personal projects and companies or individuals making less than 1M USD gross annnual revenue. Please get in touch with us if you have any question.

ajeckmans commented 2 years ago

@leastprivilege can this still be merged or do we have to look for a workaround?

leastprivilege commented 2 years ago

Even if we would merge it, we would not publish updated nugets.

The only real alternative I can think of is to move to a supported version of IdentityServer.

ajeckmans commented 2 years ago

We opted to replace the TokenCleanupService registered in the DI container with the updated one in this request.