Closed s1m-0n closed 9 years ago
Hi Simon,
What is the actual behaviour? And what behaviour do you expect?
Fraser
On 6/03/2015, at 8:01 pm, s1m0n notifications@github.com wrote:
If you are setting one of the two TextFields to "Secure Text Entry" in the Interface Builder as it is supposed for a password field, the scrolling does not work correctly any more. Didn't this bug also occur in your demo that shows the gif animation? Do you have a workaround?
\ Reply to this email directly or view it on GitHub.
The view is moving upwards to the top of the screen if you enable the "Secure Text Entry". You can reproduce this easily if you set the "Secure Text Entry" in the demo app for one TextField...Hopefully you can reproduce it and maybe already have a solution for this :)
Those are some pretty unhelpful bug descriptions - you wouldn’t make a good QA ;)
I figured out how to reproduce your issue: first you have to tap on a secure text field to trigger the avoiding, then you need to tap on a non secure one (spell check must be enabled too), iOS8 only.
I’ll be able to fix it but not sure when I’ll have the time. If you sort a fix yourself, I can pull in your changes
Thanks for raising this Fraser
On 8/03/2015, at 4:46 pm, s1m0n notifications@github.com wrote:
The view is moving to the top of the screen if you enable the "Secure Text Entry". You can reproduce this easily if you set the "Secure Text Entry" in the demo app for one TextField...Hopefully you can reproduce it and maybe already have a solution for this :)
— Reply to this email directly or view it on GitHub https://github.com/IdleHandsApps/IHKeyboardAvoiding/issues/11#issuecomment-77731248.
Ok, the description was really not a "description" :D - sorry for that! If I have time I'll have a more detailed look into that. I think it has to do something with the predictive Keyboard but I'm not sure with that...
np:)
Yeah it looks like when it changes from secure keyboard to predictive keyboard, I need to translate the height difference instead of the full keyboard height
Maybe the fix is in this guys fork https://github.com/ikesyo/IHKeyboardAvoiding/commit/d94e0319567f7f128eeca997de6fe7c024d7801d
Perfect! The fork fixes the bug - can you merge it into the your master and create a new pod release? I would do the merge on my own but I have no idea how cherry-pickin works with github and forks :) Thanks a lot!
Cool - I’ll try to do it this week
On 9/03/2015, at 4:29 pm, s1m0n notifications@github.com wrote:
Perfect! The fork fixes the bug - can you merge it into the your master and create a new pod release? I would do the merge on my own but I have no idea how cherry-pickin works with github and forks :) Thanks a lot!
— Reply to this email directly or view it on GitHub https://github.com/IdleHandsApps/IHKeyboardAvoiding/issues/11#issuecomment-77795336.
Perfekt! Thanks!
Procrastinating done - Ive pushed the fix, and a couple of other minor fixes and bumped the pod spec version.
Let me know if it looks hunky-dory
Cheers Fraser
On 9/03/2015, at 4:32 pm, s1m0n notifications@github.com wrote:
Perfekt! Thanks!
— Reply to this email directly or view it on GitHub https://github.com/IdleHandsApps/IHKeyboardAvoiding/issues/11#issuecomment-77795509.
updated the pod - works fine now! Thanks for fixing this so fast!
Cheers, Simon
If you are setting one of the two TextFields to "Secure Text Entry" in the Interface Builder as it is supposed for a password field, the scrolling does not work correctly any more. Didn't this bug also occur in your demo that shows the gif animation? Do you have a workaround?