search

IdoPesok / zsa

https://zsa.vercel.app
MIT License
436 stars 13 forks source link

Run ESLint and Typecheck on CI and use pnpm #137

Closed andresgutgon closed 1 week ago

andresgutgon commented 1 week ago

What?

Not really an issue. But a piece of feedback 😃

CI lint & Typecheck

While working in this PR https://github.com/IdoPesok/zsa/pull/124 I noticed CI is not running Linter or Typescript checks.

Is there any reason for that?

Also notice ESLint config is a big convoluted with double tsconfig.json and tsconfig.lint.json in all the packages. I think this could be simplified.

Use PNPM instead of NPM

I admit this one is not critical 😂 . But I've working in all my monorepos with pnpm is so much better experience. Faster builds and better module resolution.

IdoPesok commented 1 week ago

Good catch on the checks, just added turbo typecheck to the CI. Will work on running the linter.

With regards to the ESLint config, this is what turborepo recommends in their examples

Going to move this issue to feedback category in the new discussions page.