IdoPesok / zsa

https://zsa.vercel.app
MIT License
761 stars 23 forks source link

Should zod and react be used as peerDependencies? #150

Closed ShumRain closed 3 months ago

ShumRain commented 3 months ago

We were working in monorepo and ran into the multiversion problem when trying next-rc

next-rc package.json:

"dependencies": {
  "next": "^15.0.0-rc.0",
  "react": "^19.0.0-rc",
  "react-dom": "^19.0.0-rc",
  "zod": "^3.23.8",
  "zsa": "^0.4.0",
  "zsa-react": "^0.1.9"
}

run yarn list:

yarn list zod:
├─ next-rc@0.1.0
│  └─ zod@3.23.8
├─ zod@3.22.4 // This is the version the other local packages are using
├─ zsa-react@0.1.9
│  └─ zod@3.23.8
└─ zsa@0.4.0
   └─ zod@3.23.8

yarn list react:
├─ next-rc@0.1.0
│  └─ react@19.0.0-rc-fb9a90fa48-20240614
└─ zsa-react@0.1.9
   └─ react@18.3.1
IdoPesok commented 3 months ago

Hi, thanks for bringing this up. Working on fix now.

IdoPesok commented 3 months ago

Released! Please try upgrading to latest 🙏

(+) can you please confirm it is fixed now?

ShumRain commented 3 months ago

Released! Please try upgrading to latest 🙏

(+) can you please confirm it is fixed now?

Everything‘s fine, thank you for resolving it so quickly