search

IdoPesok / zsa

https://zsa.vercel.app
MIT License
763 stars 23 forks source link

callbacks from chained procedures should all run, not override each o… #71

Closed IdoPesok closed 4 months ago

IdoPesok commented 4 months ago

…ther

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 215099787710d706849ac28e6e63d866c7cb7647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zsa ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:21pm
WesternConcrete commented 4 months ago

Looks good! I have an open PR for some testing of zod safe function callbacks - thoughts on adding tests specifically for procedure callbacks?

IdoPesok commented 4 months ago

Looks good! I have an open PR for some testing of zod safe function callbacks - thoughts on adding tests specifically for procedure callbacks?

Yeah good idea -- can you cherry pick this commit into your testing branch and add tests for chained procedure callbacks. We can then close this PR and merge them in your PR

IdoPesok commented 4 months ago

moved to #92