search

IdreesInc / Celeste

Add shooting stars to your Minecraft server with this Spigot Plugin 💫
https://www.spigotmc.org/resources/celeste.81862/
GNU General Public License v3.0
64 stars 16 forks source link

Add support for loot tables and world-specific configs #5

Closed IdreesInc closed 2 years ago

IdreesInc commented 2 years ago

My changes can be viewed via this commit: https://github.com/IdreesInc/Celeste/commit/cea67787eee6b369081293483e482fb1f99ddf09

@Trico-Everfire

Overall your changes were very welcome upgrades, I just needed to make a few updates. Mainly, I focused on implementing backwards compatibility between old plugin versions as well as ensure that the plugin could still run on Minecraft 1.14. I've also moved some files around to make the code a bit clearer, and wrote some new logic to interpret the config files in a "hierarchical" way. By that I mean the configuration goes from Defaults -> Top Level Settings -> Per World Settings. There were also a few bugs here and there that I addressed, but nothing major.

If you get the time, please give this build a shot and report back any errors you might encounter. Also feel free to ask for clarification on any of the changes I have made. I'm going to request some feedback from people using this plugin for a bit before merging this into master, as these are some very significant changes and I don't want to miss any breaking changes. Thanks again for your work, and happy holidays!

Trico-Everfire commented 2 years ago

I've set a Review a while back, might be worth a read.

IdreesInc commented 2 years ago

I've set a Review a while back, might be worth a read.

My apologies, I can’t find what you are referring to. Mind doing me a favor and linking to it?

IdreesInc commented 2 years ago

@Trico-Everfire Also if you'd prefer to communicate over email, my email address is available on my website https://idreesinc.com