search

IdreesInc / Monocraft

A monospaced programming font inspired by the Minecraft typeface
https://idreesinc.com
SIL Open Font License 1.1
8.02k stars 115 forks source link

Take Into Account Non-integer Offsets #109

Closed Dheatly23 closed 1 year ago

Dheatly23 commented 1 year ago

This should fix non-integer margin that #98 broke. I put provisions for future y-offset too.

Dheatly23 commented 1 year ago

After thinking about it, it maybe better to put extra data as keyword argument instead of making it longer and longer. Will implement it later.

IdreesInc commented 1 year ago
Screen Shot 2023-02-12 at 4 16 11 PM

Thanks for your work on this once again! Seeing a weird issue in the generated .otf file that isn't there with the .ttf where some characters with holes like 8, O, and o are being filled in. Not sure why this is or if the previous version had this problem too

EDIT: Can confirm that the previous version also has this issue, weird that it only shows up for otf files. Will make another issue for this: https://github.com/IdreesInc/Monocraft/issues/110

IdreesInc commented 1 year ago

Can confirm that this work fixes the margin problem, thanks again for all the work you have put in to making the polygon generation possible! Will wait to release the next version until we can figure out why the above issue is happening.