IfcOpenShell / ifc-to-cityjson

4 stars 2 forks source link

radius_execution_context.cpp - error: no member named 'parameters' in namespace 'CGAL::Polygon_mesh_processing'; did you mean 'CGAL::parameters'? #1

Closed dirkolbrich closed 1 year ago

dirkolbrich commented 1 year ago

During build of IfcOpenShell v0.8.0 branch the build exits with error:

In file included from /Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:326:
In file included from /opt/homebrew/include/CGAL/Surface_mesh_simplification/edge_collapse.h:21:
In file included from /opt/homebrew/include/CGAL/Surface_mesh_simplification/internal/Edge_collapse.h:21:
In file included from /opt/homebrew/include/CGAL/Modifiable_priority_queue.h:20:
In file included from /opt/homebrew/include/boost/heap/pairing_heap.hpp:22:
/opt/homebrew/include/boost/heap/detail/tree_iterator.hpp:62:58: warning: unused parameter 'cmp' [-Wunused-parameter]
    unordered_tree_iterator_storage(ValueCompare const & cmp)
                                                         ^
/Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:407:10: warning: unused variable 'num' [-Wunused-variable]
                size_t num = std::distance(begin, end);
                       ^
/Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:452:10: warning: unused variable 'stop_ratio' [-Wunused-variable]
                double stop_ratio = 0.1;
                       ^
/Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:445:149: warning: unused parameter 'padding_volume' [-Wunused-parameter]
        void minkowski_sum_triangles_double_multithreaded(const CGAL::Polyhedron_3<CGAL::Epick>& poly_triangulated_epick, CGAL::Nef_polyhedron_3<Kernel_>& padding_volume, CGAL::Nef_polyhedron_3<Kernel_>& result) {
                                                                                                                                                           ^
/Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:602:8: warning: variable 'failed' set but not used [-Wunused-but-set-variable]
                bool failed = false;
                     ^
/Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:945:14: error: no member named 'parameters' in namespace 'CGAL::Polygon_mesh_processing'; did you mean 'CGAL::parameters'?
        auto ffim = CGAL::Polygon_mesh_processing::parameters::face_index_map(fim);
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                    CGAL::parameters
/opt/homebrew/include/CGAL/Named_function_parameters.h:427:11: note: 'CGAL::parameters' declared here
namespace parameters {
          ^
/Users/dirkolbrich/Code/ifcOpenShell/src/ifcconvert/cityjson/radius_execution_context.cpp:991:3: error: no member named 'parameters' in namespace 'CGAL::Polygon_mesh_processing'; did you mean 'CGAL::parameters'?
                CGAL::Polygon_mesh_processing::parameters::vertex_index_map(vertex_index_map));
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                CGAL::parameters
/opt/homebrew/include/CGAL/Named_function_parameters.h:427:11: note: 'CGAL::parameters' declared here
namespace parameters {
          ^

System: macOS M1 arm64 Compiler llvm clang 16 (homebrew version) CGAL: 5.6 (homebrew version)

aothms commented 1 year ago

Thanks, this seemed to be introduced in 5.5 or 5.6. I've added some compatibility macros. Should be fixed now.