IfcOpenShell / ifc-to-cityjson

4 stars 2 forks source link

common.mk -- is update needed? #3

Open thomwinans opened 2 months ago

thomwinans commented 2 months ago

On MacOS, I found that the following was needed in common.mk to ensure the sed command was properly structured:

UNAME_S := $(shell uname -s)

I also needed to update python version to current, so suggest replacing, adding:

PYTHON_VERSION := $(shell python3 --version | awk '{print $$2}' | sed 's/.0$$//') PYTHON:=python$(PYTHON_VERSION)

For Linux/MacOS, the following got rid of a warning... not sure how this works on Windows et al. PIP := $(shell which pip3)