search

IfnotFr / PopConfirm

A simple action confirmation plugin for jQuery based on Twitter Bootstrap Popover
MIT License
99 stars 35 forks source link

Tapping/clicking PopConfirm trigger more than once breaks functionality #2

Closed bhall7 closed 10 years ago

bhall7 commented 10 years ago

When tapping or clicking on a button or other item that triggers PopConfirm more than once, it makes the PopConfirm popover flash briefly and then not re-appear when the user tries to re-trigger it.

To re-create the issue, simply click on anything that triggers PopConfirm once, and then once again.

Perhaps the best solution would be to have the trigger object/button toggle the PopConfirm popover.

IfnotFr commented 10 years ago

It look that the bug appear since the Fix #1 . I will take a look, Thanks :)

auxiliary commented 10 years ago

I changed line 72 from if (last) ... to if (last && last !== self) and it got fixed.

bhall7 commented 10 years ago

That seems to have solved it, auxiliary!

IfnotFr commented 10 years ago

Yep, problem fixed, thanks :)