search

IfnotFr / PopConfirm

A simple action confirmation plugin for jQuery based on Twitter Bootstrap Popover
MIT License
99 stars 35 forks source link

I've added option for Yes Button. #26

Closed nlapshinrocks closed 8 years ago

nlapshinrocks commented 8 years ago

Now it can be configured to be in different bootstrap-class: danger, primary, success etc.

IfnotFr commented 8 years ago

Why changing the indentation ?

Nice idea by the way, but cannot identify the diff with the complete indentation change.

Could you look at it ?

nlapshinrocks commented 8 years ago

I don't know why my IDE has done it...

I've just changed 2 lines.

I've added: , yesBtnClass: 'danger'

on line 30 in var defaults = { after noBtn: 'No'

and changed 1 string on line 115 from content: options.content + '

' to content: options.content + '

'

I've replaced btn-danger to btn-' +options.yesBtnClass+ '

Tat's really good thing if you want to confirm sumething not with danger button. For example if you confirm something to accept.

I can try to make another pull-request for it or just add theese changes yourself if you like it.

IfnotFr commented 8 years ago

Okay i will take a look for doing manual editing :)

If you want to be in credits you can make another PR with good indentation ;)

nlapshinrocks commented 8 years ago

Thank you.