Issue with Amusement park function 3

[Danbaba1]

Exercise: Amusement park

Function: 3

Issue: My code is not working

export function ticketStatus(tickets, ticketId) {
  if(!tickets.ticketId){
    return ('unknown ticket id');
  } else if(tickets.ticketId == null){
    return ('not sold');
  } else if(tickets.ticketId){
    return ('sold to {name}');
  }
}

[Ifycode]

@Danbaba1 You are not completely following how I said you should go about creating issues and pull requests. It's usually easier to review using a PR than with issues. So when you create an issue, always create a PR that goes with it (a new file with the code as content of the file). Then link the PR to the issue. It's that simple.

You can see I also had to change your issue title. Please use Ideas from this so I can easily differentiate the issues. Also, tag me.

[Ifycode]

It looks like you don't understand why I'm doing it this way, so I will explain some things to you. You would apply for some tech job or scholarship etc. And some would request your Github profile. some others want to see your GitHub activities for the last 6 months etc. A not-so-active GitHub profile is not to your advantage in those cases. The things you have on your GitHub profile don't need to be for a job or a gig. The ones you do while learning too are also allowed. It shows proof of your constant learning.

So while the goal is not to fill up your Github profile, it will be to your advantage that your profile shows/reflects your learning process. If it goes ahead to showcase you're able to use git/github, it's even better. I will stop here for now.

[Ifycode]

As for the issue you are having with this code @Danbaba1 :

• Using if statement is correct.
• Using !tickets.ticketId or tickets.ticketId is just wrong.
• The null part is correct, but I advise you to use strict equality === instead of ==.
• For this part return ('sold to {name}'), since the name will be the property's value, you should use change {name} to that. And use a template literal to display it or concatenate it with +. Which ever you choose.

What you should do:

• Go back to the lesson on Objects. Revise the different ways you can access your object properties. Then while working on this task, you can use your VS code editor so that you'll be able to use console.log to test out things. For example, you can console.log(!tickets.ticketId) and see what that returns. That will give you a better idea of why your code isn't working correctly.
• And then read the current lesson in the syllabus.

[Danbaba1]

@Ifycode thank you ma for helping out.

[Danbaba1]

@Ifycode

function ticketStatus(tickets, ticketId) {
  if(ticketId in tickets.keys()){
    if(ticketId === null){
      return 'not sold';
    } else {
      return 'sold to ' + tickets.ticketId;
    }
  }
  return 'unknown ticket id';
}

it still did not work.

[Danbaba1]

@Ifycode

function ticketStatus(tickets, ticketId) {
  if(Object.keys(tickets).includes(ticketId)){
    if(tickets[ticketId] === null){
      return 'not sold';
    } else {
      return `sold to ${tickets[ticketId]}` ;
    }
  }
  return 'unknown ticket id';
}

it worked.

[Ifycode]

About the first one where you didif(ticketId in tickets.keys()), it will not work because if statement only works for setting a condition. It has nothing to do with the loop-like syntax you gave it to work with. I'm guessing you thought you could manipulate it like a for... in loop.

[Ifycode]

Nice... Now that you have a working answer... let me give you small work 😂 @Danbaba1 Nesting if or if else statements can be confusing for the reader sometimes. Even for you who wrote it. Work on the function ticketStatus(tickets, ticketId) function again. But this time, no nesting.

[Danbaba1]

@Ifycode okay ma I actually worked on the code yesterday because I really wanted it to work and it worked.