IgKh / katvan

A bare-bones editor for Typst files, with a bias for Right-to-Left editing
GNU General Public License v3.0
35 stars 3 forks source link

Ability to hide line numbers #2

Closed ThatOneCalculator closed 5 months ago

ThatOneCalculator commented 8 months ago

I think having line numbers on both the left and right of the editor is a bit much, especially when they don't match the color scheme

image

ThatOneCalculator commented 8 months ago

In my opinion, at least with left-to-right, it looks a lot better with one gutter

image

IgKh commented 5 months ago

Thanks!

Regarding to amount of line number gutters, the dual gutters are indeed unusual but they are the best way I found so far to help maintain orientation across the document when paragraphs alternate between right-to-left and left-to-right. The project's goal is specifically RTL use case - users working in LTR languages already have a good selection of far more mature editors to write Typst in. That said, now that Katvan has a configuration framework I don't see a problem with making the amount of gutters a configuration option.

Regarding the gutter color - yeah, it is hard coded and doesn't respect the system palette, so it does looks pretty awful under a dark theme. Since it is a cosmetic issue and there was more urgent functionality I needed, it was left as-is. But it does also bother me, so I aim to address it in the next release cycle.

I'll leave the issue open for both of those for now.

P.S. I also study Economics, but it is not very interesting, is it?

ThatOneCalculator commented 5 months ago

Thank you for the reply! It's not very interesting -- thankfully I'm not an econ major ^^

IgKh commented 5 months ago

Both issues addressed in version 0.5.0: