✨ [feat] Better _ensure_voice_safety() with improved locks

IgKniteDev / IgKnite

A unified, Swiss-grade bot, designed for providing fine moderation & music on Discord

https://igknitedev.github.io/docs

MIT License

72 stars 26 forks source link

Closed hitblast closed 10 months ago

hitblast commented 10 months ago

[ ] (untested) This PR introduces a new skip_play flag to the internal _ensure_voice_safety() method of the Music cog to check if there is actually something that's loaded onto the memory regardless of whether it's paused or not. This has a whole range of usage benefits and actually solves several commands which had previously stopped working due to the music being paused.
[x] Fixed broken GitHub Actions status badges in the README.md file.

hitblast commented 10 months ago

Looks like we've encountered an added layer of complexity with this. Closing the PR for now.